This is really dumb

[keinloffel]

What's the syntax error in this insert statement?

String sql = "INSERT INTO Feedback ( Name, Email, Extn, Date, Description, Alternate, Type) VALUES(" +rname+ ", " +email+ ", " +extn+ ", #" +date+ "#, " +description+ ", " +alternate+ ", " +type+ ")" ;


rname, email etc are all variables I've defined already.

date is a Date
extn is a Number
the rest are all text

the DB I'm using is MS Access.

I'm really rusty on this right now.

Thanks

[bannor]

If you're doing this in Access, try replacing the + signs with &, and insert a space between it and your variables. Also, you shouldn't need the semi colon at the end.

If I was doing it in ms-access vba I would think the line(s) would look similar to the following

Dim sSql As String
sSQL = "INSERT INTO Feedback (Name, Email, Extn, Date, Description, Alternate, Type) VALUES(" & rname & ", " & email & ", " & extn & ", #" & date & "#, " & description & ", " & alternate & ", " & type & ")"

[Rawhide]

In addition to what bannor said, I am assuming that fields like name, email, description, etc., are text fields. Your text needs to be delimited. Also, if you are using the semi-colon because it is Access, put the semi-colon inside the double quotes, not out.

Like this:

sSQL = "INSERT INTO Feedback (Name, Email, Extn, Date, Description, Alternate, Type) VALUES ('" & rname & "', '" & email & "', " & extn & ", #" & date & "#, '" & description & "', '" & alternate & "', '" & type & "');"